Bug 28881 - svn-create-patch should check if the repo path is the same when trying to find the root
Summary: svn-create-patch should check if the repo path is the same when trying to fin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-01 11:38 PDT by Anders Carlsson
Modified: 2009-09-02 18:45 PDT (History)
5 users (show)

See Also:

Attachments
Patch v1 (2.58 KB, patch)
2009-09-01 13:13 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2009-09-01 11:38:02 PDT 
Currently, when svn-create-patch checks for the repository root it only checks if the repository UUID is the same. It needs to check that the repository path is the same as well.
Comment 1 David Kilzer (:ddkilzer) 2009-09-01 12:00:21 PDT 
svn-create-patch switched from repository root to UUID in r46134.

<http://trac.webkit.org/changeset/46134>

For situations where you have two nested working directories that are from the same repository (but at different repository roots), it's necessary to check both the repository root and the UUID.
Comment 2 David Kilzer (:ddkilzer) 2009-09-01 13:13:37 PDT 
Created attachment 38881 [details]
Patch v1
Comment 3 Eric Seidel (no email) 2009-09-02 00:27:36 PDT 
Comment on attachment 38881 [details]
Patch v1

Looks good to me.  So sad that we don't have unit tests for this sort of thing. :(  It's possible to test this stuff via scm.py for sure.  cq- for ChangeLog patch and because yor'e a committer.
Comment 4 Adam Barth 2009-09-02 06:26:40 PDT 
We have this bug in one of the bugzilla-tool python modules too (probably scm.py).
Comment 5 David Kilzer (:ddkilzer) 2009-09-02 08:55:39 PDT 
Comment on attachment 38881 [details]
Patch v1

(In reply to comment #4)
> We have this bug in one of the bugzilla-tool python modules too (probably
> scm.py).

Will fix scm.py as well.
Comment 6 David Kilzer (:ddkilzer) 2009-09-02 16:52:07 PDT 
(In reply to comment #3)
> (From update of attachment 38881 [details])
> Looks good to me.  So sad that we don't have unit tests for this sort of thing.
> :(  It's possible to test this stuff via scm.py for sure.  cq- for ChangeLog
> patch and because yor'e a committer.

(In reply to comment #4)
> We have this bug in one of the bugzilla-tool python modules too (probably
> scm.py).

I filed Bug 28925 instead.  Don't have time to work on this right now, and it's not causing any known issues for WebKit contributors.
Comment 7 David Kilzer (:ddkilzer) 2009-09-02 18:45:09 PDT 
Committed r48003: <http://trac.webkit.org/changeset/48003>