RESOLVED FIXED 288691
Use Platform.h defines from Swift code 
https://bugs.webkit.org/show_bug.cgi?id=288691
Summary Use Platform.h defines from Swift code
Elliott Williams
Reported 2025-02-26 21:38:30 PST
As we write more Swift code in Apple's codebase, we wind up duplicating the platform and feature availability logic in <wtf/Platform.h> in Xcode build settings. We have to conditionally set `SWIFT_ACTIVE_COMPILATION_CONDITIONS` in xcconfigs to achieve the same behavior, and it's easy for these definitions to get out of sync. This bug tracks making Swift able to use platform definitions from their canonical location in WTF.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2025-02-26 21:39:46 PST
<rdar://problem/145717488>
Elliott Williams
Comment 2 2025-02-26 22:46:35 PST
Pull request: https://github.com/WebKit/WebKit/pull/41495
EWS
Comment 3 2025-03-05 13:03:16 PST
Committed 291648@main (168c0aee29a2): <https://commits.webkit.org/291648@main> Reviewed commits have been landed. Closing PR #41495 and removing active labels.
Elliott Williams
Comment 4 2025-03-05 16:14:45 PST
<rdar://problem/146335497>
Elliott Williams
Comment 5 2025-03-05 16:15:38 PST
Re-opening for pull request https://github.com/WebKit/WebKit/pull/41955
EWS
Comment 6 2025-03-05 16:21:50 PST
Committed 291661@main (8e711ebc97d4): <https://commits.webkit.org/291661@main> Reviewed commits have been landed. Closing PR #41955 and removing active labels.
Elliott Williams
Comment 7 2025-03-05 17:44:53 PST
Reopened Bugzilla. Revert "[Swift] Use Platform.h feature defines as compilation conditions", tracking revert in https://bugs.webkit.org/show_bug.cgi?id=289209.
Elliott Williams
Comment 8 2025-03-05 19:43:12 PST
Pull request: https://github.com/WebKit/WebKit/pull/41974
EWS
Comment 9 2025-03-07 11:45:20 PST
Committed 291794@main (dcebb661f447): <https://commits.webkit.org/291794@main> Reviewed commits have been landed. Closing PR #41974 and removing active labels.
EWS
Comment 10 2025-03-07 13:55:39 PST
Committed 291803@main (b2137e4f8c2a): <https://commits.webkit.org/291803@main> Reviewed commits have been landed. Closing PR #42104 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.