Bug 28860 - SVGSVGElement suspend methods argument/return types incorrect
Summary: SVGSVGElement suspend methods argument/return types incorrect
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Trivial
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-31 16:48 PDT by Cameron McCormack (:heycam)
Modified: 2009-09-01 04:12 PDT (History)
1 user (show)

See Also:

Attachments
Patch v1 (2.05 KB, patch)
2009-08-31 16:50 PDT, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2009-08-31 16:48:22 PDT 
Should be "unsigned" rather than "unsigned long".
Comment 1 Cameron McCormack (:heycam) 2009-08-31 16:50:49 PDT 
Created attachment 38844 [details]
Patch v1

Not adding any tests since the methods aren't implemented yet anyway.
Comment 2 Eric Seidel (no email) 2009-09-01 00:24:38 PDT 
Comment on attachment 38844 [details]
Patch v1

I would probably have called "maxWaitMilliseconds" "maxWaitInMilliseconds".  Looks fine though. :)
Comment 3 Eric Seidel (no email) 2009-09-01 00:38:31 PDT 
Comment on attachment 38844 [details]
Patch v1

Rejecting patch 38844 from commit-queue.  This patch will require manual commit.

['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1
Comment 4 Eric Seidel (no email) 2009-09-01 02:17:54 PDT 
Comment on attachment 38844 [details]
Patch v1

media/video-seeking.html -> failed

I think it's just another flakey media test. :(
Comment 5 Eric Seidel (no email) 2009-09-01 04:11:59 PDT 
Comment on attachment 38844 [details]
Patch v1

Clearing flags on attachment: 38844

Committed r47926: <http://trac.webkit.org/changeset/47926>
Comment 6 Eric Seidel (no email) 2009-09-01 04:12:03 PDT 
All reviewed patches have been landed.  Closing bug.