Text Fields and Text Areas are reported as read-only by inspect32.exe

[Brian Weinstein]

Text Fields and Text Areas are reported as read-only by inspect32.exe.

The text fields and areas that are read/write should be read/write to inspect32.exe and other tools that look at the accessibility of a node.

[Brian Weinstein]

Created attachment 38832 [details]
Fix

[Brian Weinstein]

Created attachment 38833 [details]
Fix + Removed Testing Code

[Adam Roben (:aroben)]

Comment on attachment 38833 [details]
Fix + Removed Testing Code

Can you make a regression test for this?

[Brian Weinstein]

I was having trouble with the accessibility tests on Windows, I can give it a shot though.

[Darin Adler]

Comment on attachment 38833 [details]
Fix + Removed Testing Code

> +    if (m_renderer->isTextField()) {
> +        HTMLInputElement* input = static_cast<HTMLInputElement*>(m_renderer->node());
> +        return input->readOnly();
> +    } else if (m_renderer->isTextArea()) {
> +        HTMLTextAreaElement* textArea = static_cast<HTMLTextAreaElement*>(m_renderer->node());
> +        return textArea->readOnly();
> +    }

We normally don't do else after if.

I think the code would read fine without a local variable.

    if (m_renderer->isTextField())
        return static_cast<HTMLInputElement*>(m_renderer->node())->readOnly()

Can this be tested with a regression test? I think there are accessibility-driven regression tests. If so, please add a test.

review- because of the lack of a test. If it's not possible to test this, then feel free to put up for review again.

[Brian Weinstein]

Created attachment 38842 [details]
Fix + Test Case

[Brian Weinstein]

Committed in http://trac.webkit.org/changeset/47915.