Bug 28849 - Make safariPath() work for Debug builds of Safari on Windows
Summary: Make safariPath() work for Debug builds of Safari on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-31 10:42 PDT by Adam Roben (:aroben)
Modified: 2009-08-31 11:12 PDT (History)
2 users (show)

See Also:


Attachments
Patch v1 (1.57 KB, patch)
2009-08-31 10:42 PDT, Adam Roben (:aroben)
sam: review+
Details | Formatted Diff | Diff
Fall back to a Release version of Safari if a Debug one doesn't exist (1.69 KB, patch)
2009-08-31 11:06 PDT, Adam Roben (:aroben)
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2009-08-31 10:42:31 PDT
Created attachment 38821 [details]
Patch v1

Reviewed by NOBODY (OOPS!).

* Scripts/webkitdirs.pm:
(safariPath): If the user is working with a Debug build, add the
_debug suffix to Safari.exe.
---
 2 files changed, 18 insertions(+), 3 deletions(-)
Comment 1 Adam Roben (:aroben) 2009-08-31 11:06:56 PDT
Created attachment 38822 [details]
Fall back to a Release version of Safari if a Debug one doesn't exist

<http://webkit.org/b/28849>

Reviewed by NOBODY (OOPS!).

* Scripts/webkitdirs.pm:
(safariPath): If the user is working with a Debug build, but there's
no Debug version of Safari present, fall back to using a Release
version of Safari.
---
 2 files changed, 19 insertions(+), 3 deletions(-)
Comment 2 Adam Roben (:aroben) 2009-08-31 11:12:47 PDT
Committed in r47898 and r47899.