Bug 28848 - [V8] Inlined fast paths of V8DOMWrapper::convertNodeToV8Object and V8Proxy::createWrapperFromCache.
Summary: [V8] Inlined fast paths of V8DOMWrapper::convertNodeToV8Object and V8Proxy::c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-31 10:02 PDT by Vitaly Repeshko
Modified: 2009-09-01 03:05 PDT (History)
2 users (show)

See Also:

Attachments
patch (6.98 KB, patch)
2009-08-31 10:07 PDT, Vitaly Repeshko 		no flags Details | Formatted Diff | Diff
patch: removed unused include in V8Proxy.h (6.79 KB, patch)
2009-08-31 10:24 PDT, Vitaly Repeshko 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vitaly Repeshko 2009-08-31 10:02:11 PDT 
[V8] Inlined fast paths of V8DOMWrapper::convertNodeToV8Object and V8Proxy::createWrapperFromCache.
Comment 1 Vitaly Repeshko 2009-08-31 10:07:14 PDT 
Created attachment 38818 [details]
patch
Comment 2 Vitaly Repeshko 2009-08-31 10:24:40 PDT 
Created attachment 38820 [details]
patch: removed unused include in V8Proxy.h
Comment 3 Dimitri Glazkov (Google) 2009-08-31 11:20:56 PDT 
Comment on attachment 38820 [details]
patch: removed unused include in V8Proxy.h

r=me.
Comment 4 Eric Seidel (no email) 2009-08-31 11:38:38 PDT 
Comment on attachment 38820 [details]
patch: removed unused include in V8Proxy.h

Rejecting patch 38820 from commit-queue.  This patch will require manual commit.

Failed to run "['svn', 'commit', '-m', '2009-08-31  Vitaly Repeshko  <vitalyr@chromium.org>\n\n        Reviewed by Dimitri Glazkov.\n\n        [V8] Inlined fast paths of V8DOMWrapper::convertNodeToV8Object and\n        V8Proxy::createWrapperFromCache.\n        https://bugs.webkit.org/show_bug.cgi?id=28848\n\n        * bindings/v8/V8DOMWrapper.cpp:\n        (WebCore::V8DOMWrapper::convertDocumentToV8Object): Special\n        function for document wrapping.\n        (WebCore::V8DOMWrapper::convertNewNodeToV8Object): Slow case of\n        wrapping a new node.\n        * bindings/v8/V8DOMWrapper.h:\n        (WebCore::V8DOMWrapper::convertNodeToV8Object): Extracted fast\n        path from V8DOMWrapper.cpp.\n        * bindings/v8/V8Proxy.cpp:\n        (WebCore::V8Proxy::createWrapperFromCacheSlowCase):\n        * bindings/v8/V8Proxy.h:\n        (WebCore::V8Proxy::createWrapperFromCache): Extracted fast path\n        from V8Proxy.cpp.\n']"  exit_code: 1  cwd: None
Comment 5 Adam Barth 2009-08-31 18:02:20 PDT 
Comment on attachment 38820 [details]
patch: removed unused include in V8Proxy.h

Try cq again.  Looks like a patch was landed during build / test.
Comment 6 Eric Seidel (no email) 2009-08-31 19:03:19 PDT 
Comment on attachment 38820 [details]
patch: removed unused include in V8Proxy.h

Rejecting patch 38820 from commit-queue.  This patch will require manual commit.

['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1
Comment 7 Eric Seidel (no email) 2009-09-01 02:18:39 PDT 
Comment on attachment 38820 [details]
patch: removed unused include in V8Proxy.h

fast/workers/dedicated-worker-lifecycle.html -> timed out

I suspect it's another flakey test. :(
Comment 8 Eric Seidel (no email) 2009-09-01 02:19:53 PDT 
I'll work on commit-queue error reporting next week, right now errors are kinda poor. :(
Comment 9 Eric Seidel (no email) 2009-09-01 03:05:46 PDT 
Comment on attachment 38820 [details]
patch: removed unused include in V8Proxy.h

Clearing flags on attachment: 38820

Committed r47921: <http://trac.webkit.org/changeset/47921>
Comment 10 Eric Seidel (no email) 2009-09-01 03:05:50 PDT 
All reviewed patches have been landed.  Closing bug.