RESOLVED DUPLICATE of bug 288484288478
REGRESSION(290957@main): Build broken with USE_GTK4=OFF and ENABLE_WK_WEB_EXTENSIONS=OFF 
https://bugs.webkit.org/show_bug.cgi?id=288478
Summary REGRESSION(290957@main): Build broken with USE_GTK4=OFF and ENABLE_WK_WEB_EXT...
Adrian Perez
Reported 2025-02-25 06:14:46 PST
If either -DUSE_GTK4=OFF or -DENABLE_WK_WEB_EXTENSIONS=OFF are passed to CMake, the build fails
Attachments
Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2025-02-25 06:18:45 PST
Even after a few (needed) local fixes, we can still get into this situation: ld.lld: error: duplicate symbol: webkit_web_extension_get_type >>> defined at WebKitWebExtension.cpp >>> Source/WebKit/CMakeFiles/WebKit.dir/WebProcess/InjectedBundle/API/glib/WebKitWebExtension.cpp.o:(webkit_web_extension_get_type) >>> defined at WebKitWebExtension.cpp >>> Source/WebKit/CMakeFiles/WebKit.dir/UIProcess/API/glib/WebKitWebExtension.cpp.o:(.text.webkit_web_extension_get_type+0x0) This means we cannot have WebExtensions support at all with !ENABLE(2022_GLIB_API)... unless we change the name of the newly added WebKitWebExtension to something else.
Alexey Proskuryakov
Comment 2 2025-02-25 12:55:28 PST
Is this just a dupe of bug 288484 at this point?
Adrian Perez
Comment 3 2025-02-25 13:43:04 PST
(In reply to Alexey Proskuryakov from comment #2) > Is this just a dupe of bug 288484 at this point? Yes, I intended to fix the issue first but it was getting complicated and decided instead to revert the patches that had landed on main. Let's close this as well. *** This bug has been marked as a duplicate of bug 288484 ***
Note You need to log in before you can comment on or make changes to this bug.