Bug 28847 – WebInspector: pass call frames into the frontend as a part of pausedScript event.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Currently pausedScript event initiates asynchronous call stack request. We can save a call and pass stack information as a part of pausedScript event instead.

[Pavel Feldman]

Created attachment 38815 [details]
patch

[Timothy Hatcher]

Comment on attachment 38815 [details]
patch

It seems odd to me for InspectorController to call into the injected script just for it to call InspectorController.currentCallFrame() and return back to native code. IS there a more direct approch to getting the callframe script objects?

[Pavel Feldman]

(In reply to comment #2)
> (From update of attachment 38815 [details])
> It seems odd to me for InspectorController to call into the injected script
> just for it to call InspectorController.currentCallFrame() and return back to
> native code. IS there a more direct approch to getting the callframe script
> objects?

I agree that it does look kinda weird. But the call frame serialization is rather complex and it is easier to perform it in JavaScript. It is also easier to keep frontend and injected script code in sync wrt data structures used during the serialization.

Currently I don't see any other way of handling it given that injected and frontend contexts are going to be isolated...

[Timothy Hatcher]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 38815 [details] [details])
> > It seems odd to me for InspectorController to call into the injected script
> > just for it to call InspectorController.currentCallFrame() and return back to
> > native code. IS there a more direct approch to getting the callframe script
> > objects?
> 
> I agree that it does look kinda weird. But the call frame serialization is
> rather complex and it is easier to perform it in JavaScript. It is also easier
> to keep frontend and injected script code in sync wrt data structures used
> during the serialization.

OK. I can go with that.

> Currently I don't see any other way of handling it given that injected and
> frontend contexts are going to be isolated...

How far are we away from doing the isolation and removing quarantine objects?

[Pavel Feldman]

(In reply to comment #4)
> How far are we away from doing the isolation and removing quarantine objects?

1. Database panel interaction is not yet serialized.
2. I need help with establishing these isolated contexts. There was a question to Sam pending somewhere in one of the early bugs
3. I am off for vacations next week for 14 days, so this activity will either suspend or be continued by Yury.

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/InspectorController.cpp
	M	WebCore/inspector/InspectorFrontend.cpp
	M	WebCore/inspector/InspectorFrontend.h
	M	WebCore/inspector/front-end/DOMAgent.js
	M	WebCore/inspector/front-end/ScriptsPanel.js
	M	WebCore/inspector/front-end/inspector.js
Committed r47897