Bug 28844 - V8 binding of WebSocket
Summary: V8 binding of WebSocket
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-31 03:34 PDT by Fumitoshi Ukai
Modified: 2009-09-01 16:18 PDT (History)
3 users (show)

See Also:

Attachments
V8 Bindings for WebSocket API (17.13 KB, patch)
2009-09-01 02:25 PDT, Fumitoshi Ukai 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fumitoshi Ukai 2009-08-31 03:34:07 PDT 
V8 binding of WebSocket API.
Comment 1 Fumitoshi Ukai 2009-09-01 02:25:55 PDT 
Created attachment 38851 [details]
V8 Bindings for WebSocket API


---
 10 files changed, 318 insertions(+), 1 deletions(-)
Comment 2 Adam Barth 2009-09-01 08:38:38 PDT 
Comment on attachment 38851 [details]
V8 Bindings for WebSocket API

This looks good.  I presume we already have LayoutTests from the JSC implementation?

nit:  In WebKit-land, we use FIXME instead of TODO.

Also, is there a bug on file for Worker support for WebSockets?
Comment 3 Eric Seidel (no email) 2009-09-01 08:54:25 PDT 
Comment on attachment 38851 [details]
V8 Bindings for WebSocket API

Rejecting patch 38851 from commit-queue.  This patch will require manual commit.

['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1
Comment 4 Eric Seidel (no email) 2009-09-01 09:07:52 PDT 
Comment on attachment 38851 [details]
V8 Bindings for WebSocket API

Rejecting patch 38851 from commit-queue.  This patch will require manual commit.

['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1
Comment 5 Adam Barth 2009-09-01 09:39:24 PDT 
Comment on attachment 38851 [details]
V8 Bindings for WebSocket API

Clearing flags on attachment: 38851

Committed r47941: <http://trac.webkit.org/changeset/47941>
Comment 6 Adam Barth 2009-09-01 09:39:31 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Eric Seidel (no email) 2009-09-01 16:16:30 PDT 
media/video-source-add-src.html -> crashed

The commit-queue hit bug 28845.
Comment 8 Eric Seidel (no email) 2009-09-01 16:18:26 PDT 
Sorry.  commit-queue failed because a layout test got left around from a previously failed patch:
svg/dom/smil-methods.svg -> failed

This type of error is tracked by bug 28603.