Bug 28834 - Compiling ScriptController failed because localStorage isn't defined.
Summary: Compiling ScriptController failed because localStorage isn't defined.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Critical
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-30 07:24 PDT by Maxime Simon
Modified: 2009-09-01 19:06 PDT (History)
2 users (show)

See Also:

Attachments
Patch v1 (2.09 KB, patch)
2009-08-30 07:50 PDT, Maxime Simon 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Simon 2009-08-30 07:24:01 PDT 
Since r47846, WebKit build fails on systems which didn't enable DOM_STORAGE.
So I would suggest to add #if ENABLE(DOM_STORAGE) … #endif around the code introduced by this revision. I think I can produce a patch for this, but should I also add this preprocessing around the v8 code?
Comment 1 Maxime Simon 2009-08-30 07:50:08 PDT 
Created attachment 38791 [details]
Patch v1
Comment 2 Eric Seidel (no email) 2009-08-31 03:05:39 PDT 
Comment on attachment 38791 [details]
Patch v1

I'm entertained that you fixed it for both ScriptControllers. :)

Thanks!
Comment 3 Eric Seidel (no email) 2009-08-31 03:19:01 PDT 
Comment on attachment 38791 [details]
Patch v1

Clearing flags on attachment: 38791

Committed r47887: <http://trac.webkit.org/changeset/47887>
Comment 4 Eric Seidel (no email) 2009-08-31 03:19:04 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Jeremy Orlow 2009-09-01 19:06:49 PDT 
Doh!  Sorry about that.  :-(