Bug 28830 - [Gtk] DRT needs implementation of overridePreference
Summary: [Gtk] DRT needs implementation of overridePreference
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Jan Alonzo
URL:
Keywords: Gtk
Depends on:
Blocks: 28823
  Show dependency treegraph
 
Reported: 2009-08-29 19:11 PDT by Jan Alonzo
Modified: 2009-09-01 05:06 PDT (History)
0 users

See Also:


Attachments
Patch v1 (7.91 KB, patch)
2009-08-29 19:26 PDT, Jan Alonzo
eric: review+
eric: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Alonzo 2009-08-29 19:11:48 PDT
Some tests use this already so it would be nice if we can pass those tests too.
Comment 1 Jan Alonzo 2009-08-29 19:26:01 PDT
Created attachment 38780 [details]
Patch v1
Comment 2 Eric Seidel (no email) 2009-08-31 03:13:56 PDT
Comment on attachment 38780 [details]
Patch v1

Looks great!

I would have named "toWebSettingKey" "copyAsWebSettingKey" or something.  To inform the caller that they need to release the returned string.

It's so sad that we don't have some sort of GOwnPtr for DRT to use here instead of needing to manually g_free.

Spacing:
+            if ( !(ss >> val).fail())

+    static gboolean isInitialized = false;
is not really needed, you can check !keyTable.

Please adjust a little before landing.
Comment 3 Jan Alonzo 2009-09-01 05:06:52 PDT
(In reply to comment #2)
> (From update of attachment 38780 [details])
> Looks great!
> 
> I would have named "toWebSettingKey" "copyAsWebSettingKey" or something.  To
> inform the caller that they need to release the returned string.
> 
> It's so sad that we don't have some sort of GOwnPtr for DRT to use here instead
> of needing to manually g_free.
> 
> Spacing:
> +            if ( !(ss >> val).fail())
> 
> +    static gboolean isInitialized = false;
> is not really needed, you can check !keyTable.
> 
> Please adjust a little before landing.

Adjusted. Thanks. Landed as http://trac.webkit.org/changeset/47928.