Some tests use this already so it would be nice if we can pass those tests too.
Created attachment 38780 [details] Patch v1
Comment on attachment 38780 [details] Patch v1 Looks great! I would have named "toWebSettingKey" "copyAsWebSettingKey" or something. To inform the caller that they need to release the returned string. It's so sad that we don't have some sort of GOwnPtr for DRT to use here instead of needing to manually g_free. Spacing: + if ( !(ss >> val).fail()) + static gboolean isInitialized = false; is not really needed, you can check !keyTable. Please adjust a little before landing.
(In reply to comment #2) > (From update of attachment 38780 [details]) > Looks great! > > I would have named "toWebSettingKey" "copyAsWebSettingKey" or something. To > inform the caller that they need to release the returned string. > > It's so sad that we don't have some sort of GOwnPtr for DRT to use here instead > of needing to manually g_free. > > Spacing: > + if ( !(ss >> val).fail()) > > + static gboolean isInitialized = false; > is not really needed, you can check !keyTable. > > Please adjust a little before landing. Adjusted. Thanks. Landed as http://trac.webkit.org/changeset/47928.