Bug 28814 - -[WebViewFactory AXARIAContentGroupText:] seems fragile and not cross-platform-friendly
Summary: -[WebViewFactory AXARIAContentGroupText:] seems fragile and not cross-platfor...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-28 12:00 PDT by Adam Roben (:aroben)
Modified: 2009-08-28 12:00 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2009-08-28 12:00:36 PDT
When a new ARIA group role is added, both AccessibilityObjectWrapper.mm and WebViewFactory.mm will need to be updated to provide a new description string for the new role. But because -[WebViewFactory AXARIAContentGroupText:] takes a string parameter describing the role, it will be easy to forget to update both places (e.g., someone could update AccessibilityObjectWrapper.mm but forget to update WebViewFactory.mm).

This would be less fragile if we had a separate WebViewFactory method for each ARIA group role, rather than a single method that takes the role as a parameter.

A side benefit of this is that all other ports will be aware of all the role description strings they need to provide, rather than having to look at WebViewFactory.mm to figure it out.