WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
28814
-[WebViewFactory AXARIAContentGroupText:] seems fragile and not cross-platform-friendly
https://bugs.webkit.org/show_bug.cgi?id=28814
Summary
-[WebViewFactory AXARIAContentGroupText:] seems fragile and not cross-platfor...
Adam Roben (:aroben)
Reported
2009-08-28 12:00:36 PDT
When a new ARIA group role is added, both AccessibilityObjectWrapper.mm and WebViewFactory.mm will need to be updated to provide a new description string for the new role. But because -[WebViewFactory AXARIAContentGroupText:] takes a string parameter describing the role, it will be easy to forget to update both places (e.g., someone could update AccessibilityObjectWrapper.mm but forget to update WebViewFactory.mm). This would be less fragile if we had a separate WebViewFactory method for each ARIA group role, rather than a single method that takes the role as a parameter. A side benefit of this is that all other ports will be aware of all the role description strings they need to provide, rather than having to look at WebViewFactory.mm to figure it out.
Attachments
Add attachment
proposed patch, testcase, etc.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug