Bug 28805 - [Gtk] Add view source mode API
Summary: [Gtk] Add view source mode API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2009-08-28 06:15 PDT by Jan Alonzo
Modified: 2009-08-28 08:12 PDT (History)
3 users (show)

See Also:


Attachments
Patch v1 (2.70 KB, patch)
2009-08-28 06:17 PDT, Jan Alonzo
gustavo: review+
gustavo: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Alonzo 2009-08-28 06:15:23 PDT
The Gtk port needs a view source mode API. Patch forthcoming..
Comment 1 Jan Alonzo 2009-08-28 06:17:11 PDT
Created attachment 38728 [details]
Patch v1
Comment 2 Gustavo Noronha (kov) 2009-08-28 06:28:06 PDT
Comment on attachment 38728 [details]
Patch v1

> + * webkit_web_view_set_view_source_mode:
> + * @web_view: a #WebKitWebView
> + * @mode: the mode to set the view source mode

I think using something like 'view_source_mode', although more verbose, would bring this more in line. Also, what do you think of dropping 'view' from that? set_source_mode.

> + * Set the view to be in "view source" mode. Set this before loading a uri to

"Whether the view should be in", because you'll also use this function to turn it off. Otherwise good. Xan? =D
Comment 3 Gustavo Noronha (kov) 2009-08-28 06:43:46 PDT
Comment on attachment 38728 [details]
Patch v1

Helping Xan with his Internet problems:

<xan> janm: but if you fix the docs and keep set_view_source_mode you have r+ from me ;)

Fixing the docs involve explaining why would I want view source mode (what it does).
Comment 4 Jan Alonzo 2009-08-28 08:12:56 PDT
(In reply to comment #3)
> (From update of attachment 38728 [details])
> Helping Xan with his Internet problems:
> 
> <xan> janm: but if you fix the docs and keep set_view_source_mode you have r+
> from me ;)
> 
> Fixing the docs involve explaining why would I want view source mode (what it
> does).

Thanks. Landed as http://trac.webkit.org/changeset/47865