Bug 28805 – [Gtk] Add view source mode API

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Jan Alonzo]

The Gtk port needs a view source mode API. Patch forthcoming..

[Jan Alonzo]

Created attachment 38728 [details]
Patch v1

[Gustavo Noronha (kov)]

Comment on attachment 38728 [details]
Patch v1

> + * webkit_web_view_set_view_source_mode:
> + * @web_view: a #WebKitWebView
> + * @mode: the mode to set the view source mode

I think using something like 'view_source_mode', although more verbose, would bring this more in line. Also, what do you think of dropping 'view' from that? set_source_mode.

> + * Set the view to be in "view source" mode. Set this before loading a uri to

"Whether the view should be in", because you'll also use this function to turn it off. Otherwise good. Xan? =D

[Gustavo Noronha (kov)]

Comment on attachment 38728 [details]
Patch v1

Helping Xan with his Internet problems:

<xan> janm: but if you fix the docs and keep set_view_source_mode you have r+ from me ;)

Fixing the docs involve explaining why would I want view source mode (what it does).

[Jan Alonzo]

(In reply to comment #3)
> (From update of attachment 38728 [details])
> Helping Xan with his Internet problems:
> 
> <xan> janm: but if you fix the docs and keep set_view_source_mode you have r+
> from me ;)
> 
> Fixing the docs involve explaining why would I want view source mode (what it
> does).

Thanks. Landed as http://trac.webkit.org/changeset/47865