Bug 28803 - [v8] Callbacks do not report exceptions that they throw.
Summary: [v8] Callbacks do not report exceptions that they throw.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Ben Murdoch
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-28 05:58 PDT by Ben Murdoch
Modified: 2009-08-28 11:40 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (1.95 KB, patch)
2009-08-28 09:41 PDT, Ben Murdoch 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Murdoch 2009-08-28 05:58:07 PDT 
In V8CustomVoidCallback if the callback throws an exception, that exception is not reported to WebCore.
Comment 1 Ben Murdoch 2009-08-28 09:41:34 PDT 
Created attachment 38741 [details]
Proposed patch
Comment 2 Dimitri Glazkov (Google) 2009-08-28 11:30:48 PDT 
Comment on attachment 38741 [details]
Proposed patch

r-me.
Comment 3 Eric Seidel (no email) 2009-08-28 11:40:18 PDT 
Comment on attachment 38741 [details]
Proposed patch

Clearing flags on attachment: 38741

Committed r47871: <http://trac.webkit.org/changeset/47871>
Comment 4 Eric Seidel (no email) 2009-08-28 11:40:21 PDT 
All reviewed patches have been landed.  Closing bug.