WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
288020
[HDR] Add test infrastructure to enable HDR images in layout tests
https://bugs.webkit.org/show_bug.cgi?id=288020
Summary
[HDR] Add test infrastructure to enable HDR images in layout tests
Said Abou-Hallawa
Reported
2025-02-19 15:52:56 PST
Two things will be added to support HDR images in layout tests: 1. An internal API called setHeadroomForTesting() will be added. The inputs are HTMLImageElement and a headroom as a float. This API will will override the image headroom value. So if we want to make an SDR image pretend to be an HDR image, we need to make call like this: internals.setHeadroomForTesting(image, 5); This API will eventually sets an std::optional<Headroom> member in BitmapImageSource. This setting will force the CALayer to be an HDR layer. Plus it will change the display of this image. 2. To test the display of the HDR image, BitmapImage::draw() will check if setHeadroomForTesting() was called for this image. And if this happened, it will display a golden rectangle regardless of the original contents.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2025-02-19 15:53:20 PST
<
rdar://problem/145173897
>
Said Abou-Hallawa
Comment 2
2025-02-19 15:57:14 PST
https://github.com/WebKit/WebKit/pull/40917
Said Abou-Hallawa
Comment 3
2025-02-20 11:56:39 PST
Committed
290704@main
(0f0ff23):
https://commits.webkit.org/290704@main
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug