Bug 28802 – Remove ASSERT(frame) in ResourceHandle::start (ResourceHandleCurl.cpp)

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Kwang Yul Seo]

bool ResourceHandle::start(Frame* frame)
{
    ASSERT(frame);
    ResourceHandleManager::sharedInstance()->add(this);
    return true;
}

Remove ASSERT in the first line because the frame could be null if the ResourceHandle is not associated with any frame, e.g. if we are downloading a file.

ResourceHandleSoup.cpp handles this case. Follow what ResourceHandleSoup.cpp does.

[Kwang Yul Seo]

Created attachment 38726 [details]
Remove ASSERT(frame)

Follow what ResourceHandleSoup does.

[Eric Seidel (no email)]

Comment on attachment 38726 [details]
Remove ASSERT(frame)

Mac has:
    if (!frame)
        return false;

Win does:
    // If we are no longer attached to a Page, this must be an attempted load from an
    // onUnload handler, so let's just block it.
    if (!frame->page())
        return false;

Somebody is wrong here.  I'll CC bradee.

[Eric Seidel (no email)]

Brady, see comment above about discrepancy between Mac/Win.

[Eric Seidel (no email)]

Comment on attachment 38726 [details]
Remove ASSERT(frame)

Clearing flags on attachment: 38726

Committed r47888: <http://trac.webkit.org/changeset/47888>

[Eric Seidel (no email)]

All reviewed patches have been landed.  Closing bug.