Bug 28785 - ImageDecoderFoo.cpp contains lots of copy & pasted code and should be refactored
Summary: ImageDecoderFoo.cpp contains lots of copy & pasted code and should be refactored
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Peter Kasting
URL:
Keywords:
Depends on:
Blocks: 26467
  Show dependency tree / graph
 
Reported: 2009-08-27 14:24 PDT by Peter Kasting
Modified: 2009-08-28 11:00 PDT (History)
1 user (show)

See Also:

Attachments
Prep work before moving functions into ImageDecoder.cpp (7.97 KB, patch)
2009-08-27 14:27 PDT, Peter Kasting 		no flags Details | Formatted Diff | Diff
Refactor (10.29 KB, patch)
2009-08-27 16:35 PDT, Peter Kasting 		eric: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Kasting 2009-08-27 14:24:10 PDT 
Similar to bug 27965.

Skia and Qt are the odd platforms out; for now the others should use common implementations of this stuff.
Comment 1 Peter Kasting 2009-08-27 14:27:32 PDT 
Created attachment 38687 [details]
Prep work before moving functions into ImageDecoder.cpp
Comment 2 Eric Seidel (no email) 2009-08-27 14:32:48 PDT 
Comment on attachment 38687 [details]
Prep work before moving functions into ImageDecoder.cpp

LGTM.
Comment 3 Peter Kasting 2009-08-27 14:38:49 PDT 
Comment on attachment 38687 [details]
Prep work before moving functions into ImageDecoder.cpp

Landed in r47836, clearing flags.
Comment 4 Peter Kasting 2009-08-27 16:35:58 PDT 
Created attachment 38696 [details]
Refactor

Yay for removing duplicate copies of code.
Comment 5 Eric Seidel (no email) 2009-08-27 18:04:59 PDT 
Comment on attachment 38696 [details]
Refactor

Why wouldn't we just move this into an RGBABuffer.cpp?  This is definitely better than before, but we generally try to do one-class per file.
Comment 6 Peter Kasting 2009-08-28 10:37:52 PDT 
(In reply to comment #5)
> (From update of attachment 38696 [details])
> Why wouldn't we just move this into an RGBABuffer.cpp?  This is definitely
> better than before, but we generally try to do one-class per file.

Yes, my eventual plan is to move this into a different file, in a different folder, with a different name.
Comment 7 Peter Kasting 2009-08-28 11:00:55 PDT 
Fixed in r47867.