Bug 287815 – [curl] LibreSSL SSL_read: Connection closed abruptly, errno 0 (Fatal because this is a curl debug build)

• Status: NEW
• Component: Platform

[Fujii Hironori]

If I use a debug build of libcurl.dll, some https tests fail.
For example,

  http/wpt/service-workers/check-service-worker-header.https.html [ Failure ]
  imported/w3c/web-platform-tests/cookies/secure/set-from-dom.https.sub.html [ Failure ]
  imported/w3c/web-platform-tests/urlpattern/urlpattern.https.any.worker.html [ Failure ]

If I open https://localhost:9443/WebKit/service-workers/check-service-worker-header.https.html with Windows MiniBrowser,
the following message was reported on the debug console.

> LibreSSL SSL_read: Connection closed abruptly, errno 0 (Fatal because this is a curl debug build)

To use a debug build of libcurl.dll, copy libcurl.dll and zlib1.dll from WebKitLibraries/win/debug/bin directory to WebKitLibraries/win/bin or WebKitBuild/Debug/bin directories.

However, due to another libcurl bug bug#286788, libcurl is going to abort quickly now. You need to compile libcurl with the DEBUGASSERT(NULL) commented out.

[Fujii Hironori]

curl.exe also reports an error.

> curl.exe -k https://localhost:9443/WebKit/service-workers/check-service-worker-header.https.html
> (...)
> curl: (56) Failure when receiving data from the peer

[Fujii Hironori]

This is the code of "Fatal because this is a curl debug build".
https://github.com/curl/curl/blob/61f85bf9678952039efc220591a264620909ac5d/lib/vtls/openssl.c#L5217-L5242

This seems to be curl's intention.
https://github.com/curl/curl/issues?q=is%3Aissue%20%22Fatal%20because%20this%20is%20a%20curl%20debug%20build%22%20
https://github.com/curl/curl/issues/15669#issuecomment-2514419251

[Fujii Hironori]

CurlRequestScheduler::completeTransfer gets CURLE_OK with a release build of libcurl.dll, but CURLE_RECV_ERROR with a debug build.

[Fujii Hironori]

I use this patch to dump libcurl debug log to the debug console.

diff --git a/Source/WebCore/platform/network/curl/CurlRequest.cpp b/Source/WebCore/platform/network/curl/CurlRequest.cpp
index 950dbeadadf1..3f0dd3d0c481 100644
--- a/Source/WebCore/platform/network/curl/CurlRequest.cpp
+++ b/Source/WebCore/platform/network/curl/CurlRequest.cpp
@@ -512,6 +512,7 @@ int CurlRequest::didReceiveDebugInfo(curl_infotype type, std::span<const char> d
 {
     if (!data.data())
         return 0;
+    OutputDebugStringA(data.data());
 
     if (type == CURLINFO_HEADER_OUT) {
         String requestHeader(data);

[Fujii Hironori]

Created attachment 474276 [details]
workaround patch for libcurl 8.12.1

[Fujii Hironori]

Run wpt server by invoking "python wpt.py serve" in another terminal.
If I specify a pipe, the error doesn't happen.

> PS C:\> curl --no-progress-meter -ko NUL https://web-platform.test:8443/acid/README.md
> curl: (56) Failure when receiving data from the peer
> PS C:\> curl --no-progress-meter -ko NUL https://web-platform.test:8443/acid/README.md?pipe=sub

[Fujii Hironori]

This is a workaround patch.

diff --git a/LayoutTests/imported/w3c/web-platform-tests/tools/wptserve/wptserve/handlers.py b/LayoutTests/imported/w3c/web-platform-tests/tools/wptserve/wptserve/handlers.py
index 62faf47d6456..5b302f03bb54 100644
--- a/LayoutTests/imported/w3c/web-platform-tests/tools/wptserve/wptserve/handlers.py
+++ b/LayoutTests/imported/w3c/web-platform-tests/tools/wptserve/wptserve/handlers.py
@@ -243,7 +243,7 @@ class FileHandler:
         """Return either the handle to a file, or a string containing
         the content of a chunk of the file, if we have a range request."""
         if byte_ranges is None:
-            return open(path, 'rb')
+            return open(path, 'rb').read()
         else:
             with open(path, 'rb') as f:
                 response.status = 206