WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
28768
No need to blacklist the QuickTime plugin
https://bugs.webkit.org/show_bug.cgi?id=28768
Summary
No need to blacklist the QuickTime plugin
Cédric Luthi
Reported
2009-08-27 02:01:56 PDT
Created
attachment 38663
[details]
Unblacklist the QuickTime plugin Now that the drawing model is properly negotiated, there is no need the blacklist the QuickTime plugin anymore. This revealed a bug in PluginView::performRequest: it should not initiate a request if the plugin has been stopped, which is what happens when a plugin only supports the QuickDraw drawing model.
Attachments
Unblacklist the QuickTime plugin
(1.25 KB, patch)
2009-08-27 02:01 PDT
,
Cédric Luthi
vestbo
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Tor Arne Vestbø
Comment 1
2009-08-28 06:43:03 PDT
Comment on
attachment 38663
[details]
Unblacklist the QuickTime plugin
> diff --git a/src/3rdparty/webkit/WebCore/plugins/PluginView.cpp b/src/3rdparty/webkit/WebCore/plugins/PluginView.cpp
I'll land this one, but in the future you should make you changes on top of WebKit from SVN, not the version in Qt. Tor Arne
Tor Arne Vestbø
Comment 2
2009-08-28 06:58:43 PDT
Committing to
http://svn.webkit.org/repository/webkit/trunk
... M WebCore/ChangeLog M WebCore/plugins/PluginView.cpp M WebCore/plugins/mac/PluginPackageMac.cpp Committed
r47863
M WebCore/plugins/mac/PluginPackageMac.cpp M WebCore/plugins/PluginView.cpp M WebCore/ChangeLog
r47863
= 37020cd0ecb8a7a8cfd591732fecb403f8a8e69b (svn/trunk)
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug