We should add a Chromium-specific SQLite VFS for Linux and Mac (just like we did for Windows) to support HTML5 DBs on all 3 platforms.
A significant part of the review was already done at http://codereview.chromium.org/173205/show.
Created attachment 38640 [details] patch
Comment on attachment 38640 [details] patch > - // open databases using Chromium's VFS > + // open databases using the default VFS > + // in renderers, it should be Chromium's VFS; in the browser process it should be SQLite's default VFS > return sqlite3_open_v2(fileName.utf8().data(), database, > SQLITE_OPEN_READWRITE | SQLITE_OPEN_CREATE | SQLITE_OPEN_FULLMUTEX, > - "chromium_vfs"); > + NULL); 0 is WebKit style. Otherwise, LGTM.
Created attachment 38747 [details] patch Replaced NULL with 0.
Comment on attachment 38747 [details] patch r=me.
Comment on attachment 38747 [details] patch It's a two-sided patch. Out the queue we go.
Comment on attachment 38747 [details] patch Clearing flags on attachment: 38747 Committed r47874: <http://trac.webkit.org/changeset/47874>
All reviewed patches have been landed. Closing bug.