Bug 28750 - Add a Linux and Mac SQLite VFS for Chromium
Summary: Add a Linux and Mac SQLite VFS for Chromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-26 13:16 PDT by Dumitru Daniliuc
Modified: 2009-08-28 14:44 PDT (History)
8 users (show)

See Also:


Attachments
patch (17.43 KB, patch)
2009-08-26 15:24 PDT, Dumitru Daniliuc
dglazkov: review-
Details | Formatted Diff | Diff
patch (17.32 KB, patch)
2009-08-28 12:56 PDT, Dumitru Daniliuc
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dumitru Daniliuc 2009-08-26 13:16:00 PDT
We should add a Chromium-specific SQLite VFS for Linux and Mac (just like we did for Windows) to support HTML5 DBs on all 3 platforms.
Comment 1 Dumitru Daniliuc 2009-08-26 13:20:36 PDT
A significant part of the review was already done at http://codereview.chromium.org/173205/show.
Comment 2 Dumitru Daniliuc 2009-08-26 15:24:29 PDT
Created attachment 38640 [details]
patch
Comment 3 Dimitri Glazkov (Google) 2009-08-28 12:34:52 PDT
Comment on attachment 38640 [details]
patch

> -    // open databases using Chromium's VFS
> +    // open databases using the default VFS
> +    // in renderers, it should be Chromium's VFS; in the browser process it should be SQLite's default VFS
>      return sqlite3_open_v2(fileName.utf8().data(), database,
>                             SQLITE_OPEN_READWRITE | SQLITE_OPEN_CREATE | SQLITE_OPEN_FULLMUTEX,
> -                           "chromium_vfs");
> +                           NULL);
0 is WebKit style.

Otherwise, LGTM.
Comment 4 Dumitru Daniliuc 2009-08-28 12:56:59 PDT
Created attachment 38747 [details]
patch

Replaced NULL with 0.
Comment 5 Dimitri Glazkov (Google) 2009-08-28 13:01:36 PDT
Comment on attachment 38747 [details]
patch

r=me.
Comment 6 Dimitri Glazkov (Google) 2009-08-28 13:26:40 PDT
Comment on attachment 38747 [details]
patch

It's a two-sided patch. Out the queue we go.
Comment 7 Ojan Vafai 2009-08-28 14:44:46 PDT
Comment on attachment 38747 [details]
patch

Clearing flags on attachment: 38747

Committed r47874: <http://trac.webkit.org/changeset/47874>
Comment 8 Ojan Vafai 2009-08-28 14:44:51 PDT
All reviewed patches have been landed.  Closing bug.