RESOLVED FIXED Bug 28743
XMLHttpRequest.withCredentials=false shouldn't save cookies. 
https://bugs.webkit.org/show_bug.cgi?id=28743
Summary XMLHttpRequest.withCredentials=false shouldn't save cookies.
David Levin
Reported 2009-08-26 10:21:36 PDT
WebKit does this correctly but there is no test for this.
Attachments
Proposed fix. (18.71 KB, patch)
2009-08-26 10:45 PDT, David Levin 		levin: commit-queue-
DetailsFormatted DiffDiff
Proposed fix. (19.84 KB, patch)
2009-08-26 12:25 PDT, David Levin 		ap: review+
levin: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2009-08-26 10:45:38 PDT
Created attachment 38622 [details] Proposed fix.
David Levin
Comment 2 2009-08-26 10:47:14 PDT
Comment on attachment 38622 [details] Proposed fix. I'd like to commit this myself so I can do the changes needed for the Chromium LayoutTestController before committing.
Alexey Proskuryakov
Comment 3 2009-08-26 11:47:40 PDT
Comment on attachment 38622 [details] Proposed fix. The WK-cross-origin cookie is already set by existing tests - what ensures that the tests won't conflict? Does anything reset the cookie accept policy back after the test finishes?
David Levin
Comment 4 2009-08-26 11:52:22 PDT
(In reply to comment #3) > (From update of attachment 38622 [details]) > The WK-cross-origin cookie is already set by existing tests - what ensures that > the tests won't conflict? It works due to the different value but having a different name would be best. > Does anything reset the cookie accept policy back after the test finishes? Right now that is done in resetDefaultsToConsistentValues() which is where a lot of these things seem to get set back to default values. (I had done this in the destructor at one point.)
David Levin
Comment 5 2009-08-26 12:07:54 PDT
Comment on attachment 38622 [details] Proposed fix. new patch in progress.
David Levin
Comment 6 2009-08-26 12:25:36 PDT
Created attachment 38630 [details] Proposed fix.
Alexey Proskuryakov
Comment 7 2009-08-26 12:36:35 PDT
Comment on attachment 38630 [details] Proposed fix. r=me
David Levin
Comment 8 2009-08-26 13:48:51 PDT
Committed as http://trac.webkit.org/changeset/47792
Note You need to log in before you can comment on or make changes to this bug.