Bug 28741 – [GTK] Out-of-srcdir build problem

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Priit Laes (IRC: plaes)]

Doing an out-of-sourcedir build (builddir != srcdir) is not working correctly:

[snip]
  GEN    DerivedSources/webkitenumtypes.cpp
echo "extern \"C\" {" > ./DerivedSources/webkitmarshal.cpp && \
	@echo "  GEN   " stamp-webkitmarshal.cpp;/usr/bin/glib-genmarshal --prefix=webkit_marshal ../WebKit/gtk/webkitmarshal.list --body >> ./DerivedSources/webkitmarshal.cpp && echo '}' >> ./DerivedSources/webkitmarshal.cpp && \
	echo timestamp > stamp-webkitmarshal.cpp
/bin/sh: line 1: @echo: käsku ei ole
  GEN    stamp-webkitmarshal.h
Can't open WebKit/gtk/webkit/webkitversion.h: No such file or directory at /usr/bin/glib-mkenums line 281.
  GEN    stamp-webkitenumtypes.h
cd . && /bin/sh ./config.status autotoolsconfig.h
Can't open WebKit/gtk/webkit/webkitversion.h: No such file or directory at /usr/bin/glib-mkenums line 281.
[/snip]

This is because WebKit/gtk/webkit/webkitversion.h is generated by configure and is placed into builddir, but mkenums script is looking for it in srcdir.

[Priit Laes (IRC: plaes)]

Created attachment 38621 [details]
webkit-bug-28741-fix-out-of-srcdir-build.patch

This fixes the issue, but cannot committed until glib-2.22 hits mainline (as glib-mkenums @basename@ syntax is available since 2.22)

[Xan Lopez]

(In reply to comment #1)
> Created an attachment (id=38621) [details]
> webkit-bug-28741-fix-out-of-srcdir-build.patch
> 
> This fixes the issue, but cannot committed until glib-2.22 hits mainline (as
> glib-mkenums @basename@ syntax is available since 2.22)

This looks reasonable to me if you add a requirement for glib >= 2.21.5 in our configure.ac (and mark the patch for review when you upload it!).

[Priit Laes (IRC: plaes)]

Created attachment 38659 [details]
webkit-bug-28741-fix-out-of-srcdir-build-v2.patch

Bumped glib version check and also fixed problem seen when generating marshals..

[Xan Lopez]

Comment on attachment 38659 [details]
webkit-bug-28741-fix-out-of-srcdir-build-v2.patch

Seems to work ok, thanks!

[Xan Lopez]

Comment on attachment 38659 [details]
webkit-bug-28741-fix-out-of-srcdir-build-v2.patch

We need to update the bot before committing this, marking - in the commit-queue.

[Xan Lopez]

Landed in r47811, closing.