Bug 28740 - Factor out summary bar from Resources panel to reuse it in Heap profile view
Summary: Factor out summary bar from Resources panel to reuse it in Heap profile view
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-26 08:15 PDT by Mikhail Naganov
Modified: 2009-08-27 09:35 PDT (History)
3 users (show)

See Also:


Attachments
Proposed patch (32.34 KB, patch)
2009-08-26 08:20 PDT, Mikhail Naganov
timothy: review-
Details | Formatted Diff | Diff
Comment addressed. (32.36 KB, patch)
2009-08-27 08:54 PDT, Mikhail Naganov
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Naganov 2009-08-26 08:15:29 PDT
The iTunes-like summary bar is currently private in Resources panel. As we want to reuse it in Heap profile view, it needs to be factored out as a separate component.
Comment 1 Mikhail Naganov 2009-08-26 08:20:57 PDT
Created attachment 38614 [details]
Proposed patch
Comment 2 Timothy Hatcher 2009-08-27 08:38:32 PDT
Comment on attachment 38614 [details]
Proposed patch

> +        return this.calculator_;
> +        this.calculator_ = x;

Our coding style uses prefix underscores for private members/functions.

Looks good otherwise.
Comment 3 Mikhail Naganov 2009-08-27 08:54:29 PDT
Created attachment 38672 [details]
Comment addressed.
Comment 4 Pavel Feldman 2009-08-27 09:10:28 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/WebCore.gypi
	M	WebCore/WebCore.vcproj/WebCore.vcproj
	M	WebCore/inspector/front-end/ResourcesPanel.js
	M	WebCore/inspector/front-end/WebKit.qrc
	M	WebCore/inspector/front-end/inspector.css
	M	WebCore/inspector/front-end/inspector.html
Committed r47822
Comment 5 Pavel Feldman 2009-08-27 09:35:46 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	A	WebCore/inspector/front-end/SummaryBar.js
Committed r47823