Bug 28739 - [V8] setTimeout does not convert non-string argument to string
Summary: [V8] setTimeout does not convert non-string argument to string
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-26 07:45 PDT by Mads Ager
Modified: 2009-08-26 12:55 PDT (History)
2 users (show)

See Also:

Attachments
Convert setTimeout argument to string if non-string (2.65 KB, patch)
2009-08-26 07:53 PDT, Mads Ager 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mads Ager 2009-08-26 07:45:13 PDT 
LayoutTests/fast/dom/Window/setTimeout-string-argument.html

fails with V8 because we do not convert a non-string argument to a string.

Patch on its way.
Comment 1 Mads Ager 2009-08-26 07:53:05 PDT 
Created attachment 38613 [details]
Convert setTimeout argument to string if non-string
Comment 2 Dimitri Glazkov (Google) 2009-08-26 08:03:10 PDT 
Comment on attachment 38613 [details]
Convert setTimeout argument to string if non-string

r=me.
Comment 3 Eric Seidel (no email) 2009-08-26 11:11:20 PDT 
Comment on attachment 38613 [details]
Convert setTimeout argument to string if non-string

Rejecting patch 38613 from commit-queue.  This patch will require manual commit.

['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1
Comment 4 Eric Seidel (no email) 2009-08-26 12:32:03 PDT 
Comment on attachment 38613 [details]
Convert setTimeout argument to string if non-string

accessibility/nochildren-elements.html -> crashed

Seems unrelated.
Comment 5 Eric Seidel (no email) 2009-08-26 12:55:22 PDT 
Comment on attachment 38613 [details]
Convert setTimeout argument to string if non-string

Clearing flags on attachment: 38613

Committed r47786: <http://trac.webkit.org/changeset/47786>
Comment 6 Eric Seidel (no email) 2009-08-26 12:55:26 PDT 
All reviewed patches have been landed.  Closing bug.