Bug 28731 - Setting the volume of a media element has no effect if called too early
Summary: Setting the volume of a media element has no effect if called too early
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2009-08-25 21:34 PDT by Eric Carlson
Modified: 2009-08-25 22:14 PDT (History)
1 user (show)

See Also:

Attachments
proposed patch (2.80 KB, patch)
2009-08-25 21:56 PDT, Eric Carlson 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2009-08-25 21:34:05 PDT 
On OSX, setting the volume of an audio element before it has loaded metadata has no effect because MediaPlayerPrivate::setVolume() bails if metaDataAvailable() is false. This is unnecessary, it is safe to set the movie volume as soon as the movie exists.
Comment 1 Eric Carlson 2009-08-25 21:34:48 PDT 
rdar://7170177
Comment 2 Eric Carlson 2009-08-25 21:56:33 PDT 
Created attachment 38596 [details]
proposed patch
Comment 3 Eric Carlson 2009-08-25 22:14:09 PDT 
http://trac.webkit.org/changeset/47771