Bug 28728 - DocumentThreadableLoader::getShouldUseCredentialStorage should allow for synchronous callbacks from SubresourceLoader::create.
Summary: DocumentThreadableLoader::getShouldUseCredentialStorage should allow for sync...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-25 19:21 PDT by David Levin
Modified: 2009-08-25 20:03 PDT (History)
1 user (show)

See Also:

Attachments
Proposed fix. (2.25 KB, patch)
2009-08-25 19:27 PDT, David Levin 		mjs: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2009-08-25 19:21:24 PDT 
On Chromium, it is useful to make this callback synchronously.

These are some small changes to stop asserts from happening in this case.
Comment 1 David Levin 2009-08-25 19:27:49 PDT 
Created attachment 38587 [details]
Proposed fix.
Comment 2 Maciej Stachowiak 2009-08-25 19:51:07 PDT 
Comment on attachment 38587 [details]
Proposed fix.

r=me
Comment 3 David Levin 2009-08-25 20:03:09 PDT 
Committed as http://trac.webkit.org/changeset/47770