RESOLVED FIXED287265
[HDR] Separate "is showing HDR" from screenContentsFormat() 
https://bugs.webkit.org/show_bug.cgi?id=287265
Summary [HDR] Separate "is showing HDR" from screenContentsFormat()
Said Abou-Hallawa
Reported 2025-02-07 10:31:48 PST
This function is a little confusing. It returns the best screen ContentsFormat for a given optional layer. I think the right design for this is 1. screenContentsFormat() should renamed screenContentsFormats() and it should return OptionSet<ContentsFormat>. The screen is capable of supporting multiple ContentsFormat. The layer should picks whatever suits it. 2. A new static function is added called PlatformCALayer::contentsFormatForLayer(). It will return the best screen ContentsFormat for a given optional layer. This function will call screenContentsFormats() and it will checks whether the PlatformCALayerClient wants to show HDR or not. If it does and the screen support RGBA16F, it will return RGBA16F.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2025-02-07 10:32:06 PST
<rdar://problem/144396500>
Said Abou-Hallawa
Comment 2 2025-02-07 10:38:26 PST
Pull request: https://github.com/WebKit/WebKit/pull/40225
EWS
Comment 3 2025-02-07 19:04:53 PST
Committed 290069@main (01e5e2df42c3): <https://commits.webkit.org/290069@main> Reviewed commits have been landed. Closing PR #40225 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.