WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
287215
Try migrating webkitpy.benchmark_runner.http_server_driver.http_server.builtin_http_server to ThreadingHTTPServer
https://bugs.webkit.org/show_bug.cgi?id=287215
Summary
Try migrating webkitpy.benchmark_runner.http_server_driver.http_server.builti...
Sam Sneddon [:gsnedders]
Reported
2025-02-06 19:30:10 PST
Since Python 3.7, ThreadingHTTPServer is finally documented. Per its documentation:
> This is useful to handle web browsers pre-opening sockets, on which HTTPServer would wait indefinitely.
We've been using this in wptserve for long before it was documented with essentially no flakiness observed, so it seems highly likely to be a win here. It may also resolve the bug described within
bug 287213
, though obviously the summary of the bug is recommending a specific solution there.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2025-02-06 19:30:19 PST
<
rdar://problem/144358027
>
Sam Sneddon [:gsnedders]
Comment 2
2025-02-06 19:41:48 PST
Pull request:
https://github.com/WebKit/WebKit/pull/40184
EWS
Comment 3
2025-02-06 21:39:14 PST
Committed
289986@main
(f3615e97b23e): <
https://commits.webkit.org/289986@main
> Reviewed commits have been landed. Closing PR #40184 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug