Bug 28720 - [V8] Fix Canvas layout test failures in Chromium build.
Summary: [V8] Fix Canvas layout test failures in Chromium build.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jian Li
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-25 15:22 PDT by Jian Li
Modified: 2009-08-25 15:39 PDT (History)
2 users (show)

See Also:


Attachments
Proposed Patch (2.98 KB, patch)
2009-08-25 15:26 PDT, Jian Li
levin: review+
jianli: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jian Li 2009-08-25 15:22:55 PDT
Fix Canvas layout test failures in Chromium build. The previous fix r47757 does not handle the V8 object conversion correctly.
Comment 1 Jian Li 2009-08-25 15:26:49 PDT
Created attachment 38571 [details]
Proposed Patch
Comment 2 David Levin 2009-08-25 15:32:06 PDT
Comment on attachment 38571 [details]
Proposed Patch


> diff --git a/WebCore/bindings/v8/custom/V8DocumentCustom.cpp b/WebCore/bindings/v8/custom/V8DocumentCustom.cpp
> +        ASSERT(false);

Use ASSERT_NOT_REACHED();

>  } // namespace WebCore
> diff --git a/WebCore/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp b/WebCore/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp
> +        ASSERT(false);

Use ASSERT_NOT_REACHED();
Comment 3 Jian Li 2009-08-25 15:39:41 PDT
Committed as http://trac.webkit.org/changeset/47758