RESOLVED FIXED 287162
[GStreamer] Refactor away MediaPlayerPrivateGStreamer::m_isPausedByViewport 
https://bugs.webkit.org/show_bug.cgi?id=287162
Summary [GStreamer] Refactor away MediaPlayerPrivateGStreamer::m_isPausedByViewport
Alicia Boya García
Reported 2025-02-06 09:40:32 PST
This is a follow-up of the cleanups discussed in https://github.com/WebKit/WebKit/pull/39765. This patch combines m_isPausedByViewport and m_invisiblePlayerState into one single field and renames it to m_stateToRestoreWhenVisible. The field is set to VOID_PENDING when we're not paused by viewport. Additionally, safeguards have been added to setVisibleInViewport() to prevent the suspension code from accidentally running more than once.
Attachments
Add attachment proposed patch, testcase, etc.
Alicia Boya García
Comment 1 2025-02-06 09:41:09 PST
Pull request: https://github.com/WebKit/WebKit/pull/40129
EWS
Comment 2 2025-02-07 05:36:29 PST
Committed 289997@main (bafa3f6bc15f): <https://commits.webkit.org/289997@main> Reviewed commits have been landed. Closing PR #40129 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.