Bug 28713 - PLATFORM(CFNETWORK) should be USE(CFNETWORK).
Summary: PLATFORM(CFNETWORK) should be USE(CFNETWORK).
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-25 09:49 PDT by David Levin
Modified: 2009-08-25 11:30 PDT (History)
2 users (show)

See Also:


Attachments
Proposed fix. (2.84 KB, patch)
2009-08-25 09:53 PDT, David Levin
eric: review+
eric: commit-queue-
Details | Formatted Diff | Diff
Proposed fix. (4.00 KB, patch)
2009-08-25 10:58 PDT, David Levin
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2009-08-25 09:49:37 PDT
http://trac.webkit.org/changeset/44267 did this in WebKit/win/WebError.cpp
http://trac.webkit.org/changeset/45505 did this in WebKitTools/DumpRenderTree/win/DumpRenderTree.cpp
Comment 1 David Levin 2009-08-25 09:53:56 PDT
Created attachment 38552 [details]
Proposed fix.
Comment 2 Eric Seidel (no email) 2009-08-25 10:23:28 PDT
Looks fine to me.  CCing adam so he sees this go by.
Comment 3 Eric Seidel (no email) 2009-08-25 10:23:53 PDT
Comment on attachment 38552 [details]
Proposed fix.

LGTM.  You can cq+ this yourself if you like.
Comment 4 Adam Roben (:aroben) 2009-08-25 10:28:42 PDT
Comment on attachment 38552 [details]
Proposed fix.

This looks good.

Let's define WTF_PLATFORM_CFNETWORK to something that will cause a compiler error that explains the problem. Something like:

#define WTF_PLATFORM_CFNETWORK USE_macro_should_be_used_with_CFNETWORK
Comment 5 David Levin 2009-08-25 10:58:03 PDT
Created attachment 38556 [details]
Proposed fix.
Comment 6 Adam Roben (:aroben) 2009-08-25 11:24:04 PDT
Comment on attachment 38556 [details]
Proposed fix.

r=me
Comment 7 David Levin 2009-08-25 11:30:28 PDT
Committed as https://bugs.webkit.org/show_bug.cgi?id=28713