WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
287079
[JSC] Use C++ concepts to constrain `Delegate` type parameter for `Yarr::parse()`
https://bugs.webkit.org/show_bug.cgi?id=287079
Summary
[JSC] Use C++ concepts to constrain `Delegate` type parameter for `Yarr::pars...
Tetsuharu Ohzeki [UTC+9]
Reported
2025-02-05 02:00:05 PST
`Yarr::parse()` has `Delegate` typeparameter but its constraint is documented as a comment in our code, not like an abstract class. -
https://github.com/WebKit/WebKit/blob/446d00e44d23eba2d8c1c1c92bf0171472dee385/Source/JavaScriptCore/yarr/YarrParser.h#L2109-L2195
-
https://github.com/WebKit/WebKit/blob/446d00e44d23eba2d8c1c1c92bf0171472dee385/Source/JavaScriptCore/yarr/YarrPattern.cpp#L1002
-
https://github.com/WebKit/WebKit/blob/446d00e44d23eba2d8c1c1c92bf0171472dee385/Source/JavaScriptCore/yarr/YarrSyntaxChecker.cpp#L34-L59
We can use a concepts for its constraint, I think.
Attachments
Add attachment
proposed patch, testcase, etc.
Tetsuharu Ohzeki [UTC+9]
Comment 1
2025-02-05 02:24:46 PST
Pull request:
https://github.com/WebKit/WebKit/pull/40045
Radar WebKit Bug Importer
Comment 2
2025-02-12 02:01:43 PST
<
rdar://problem/144681864
>
EWS
Comment 3
2025-02-20 05:53:06 PST
Committed
290702@main
(be68a2f3be90): <
https://commits.webkit.org/290702@main
> Reviewed commits have been landed. Closing PR #40045 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug