RESOLVED FIXED 286964
snappedSelectionRect() has redundant parameters 
https://bugs.webkit.org/show_bug.cgi?id=286964
Summary snappedSelectionRect() has redundant parameters
fantasai
Reported 2025-02-03 14:48:54 PST
In LayoutRect snappedSelectionRect(const LayoutRect& selectionRect, float logicalRight, float selectionTop, float selectionHeight, bool isHorizontal) we are effectively passing the selectionTop and selectionHeight parameters twice: once inside the selectionRect, and a second time as independent float values. We should just pass them once.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2025-02-03 14:49:13 PST
<rdar://problem/144117546>
fantasai
Comment 2 2025-02-03 15:34:05 PST
Pull request: https://github.com/WebKit/WebKit/pull/39940
EWS
Comment 3 2025-02-03 21:59:40 PST
Committed 289768@main (43e213f4cdb0): <https://commits.webkit.org/289768@main> Reviewed commits have been landed. Closing PR #39940 and removing active labels.
EWS
Comment 4 2025-02-14 11:04:59 PST
Committed 289651.115@safari-7621-branch (72390b9d0e97): <https://commits.webkit.org/289651.115@safari-7621-branch> Reviewed commits have been landed. Closing PR #2598 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.