Bug 28680 - WebInspector: Simplify findTreeElement code, get rid of potential infinite loop.
Summary: WebInspector: Simplify findTreeElement code, get rid of potential infinite loop.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-24 12:07 PDT by Pavel Feldman
Modified: 2009-08-24 13:27 PDT (History)
1 user (show)

See Also:


Attachments
patch (9.33 KB, patch)
2009-08-24 12:09 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
oops - brought isDescendant back (deleted too much). (10.29 KB, patch)
2009-08-24 12:19 PDT, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-08-24 12:07:08 PDT
Currently searching for inline node text can lead to infinite loop.
Comment 1 Pavel Feldman 2009-08-24 12:09:26 PDT
Created attachment 38490 [details]
patch
Comment 2 Pavel Feldman 2009-08-24 12:19:19 PDT
Created attachment 38491 [details]
oops - brought isDescendant back (deleted too much).
Comment 3 Pavel Feldman 2009-08-24 13:27:34 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/ElementsPanel.js
	M	WebCore/inspector/front-end/ElementsTreeOutline.js
	M	WebCore/inspector/front-end/treeoutline.js
	M	WebCore/inspector/front-end/utilities.js
Committed r47725