Bug 28678 - WebInspector: Only expand local scope when hitting the break
Summary: WebInspector: Only expand local scope when hitting the break
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-24 08:39 PDT by Pavel Feldman
Modified: 2009-08-24 13:21 PDT (History)
1 user (show)

See Also:

Attachments
patch (1.28 KB, patch)
2009-08-24 08:41 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
same with unused parameter cleanup (1.86 KB, application/octet-stream)
2009-08-24 09:05 PDT, Pavel Feldman 		no flags Details
same with unused parameter cleanup (1.86 KB, patch)
2009-08-24 09:06 PDT, Pavel Feldman 		timothy: review+
Details | Formatted Diff | Diff
second part of the fix (1.60 KB, patch)
2009-08-24 12:22 PDT, Pavel Feldman 		timothy: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-08-24 08:39:52 PDT 
Currently all the scopes are being expanded (CallFrame change regression).
Comment 1 Pavel Feldman 2009-08-24 08:41:02 PDT 
Created attachment 38480 [details]
patch
Comment 2 Pavel Feldman 2009-08-24 09:05:18 PDT 
Created attachment 38481 [details]
same with unused parameter cleanup
Comment 3 Pavel Feldman 2009-08-24 09:06:08 PDT 
Created attachment 38482 [details]
same with unused parameter cleanup
Comment 4 Pavel Feldman 2009-08-24 09:41:22 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/InjectedScript.js
	M	WebCore/inspector/front-end/ScopeChainSidebarPane.js
Committed r47717
Comment 5 Pavel Feldman 2009-08-24 12:22:57 PDT 
Created attachment 38492 [details]
second part of the fix

First patch prevents _all_ scopes from being expanded, which is not enough.
I missed the part where local one is expanded.
Comment 6 Pavel Feldman 2009-08-24 13:21:20 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/ScopeChainSidebarPane.js
Committed r47724