RESOLVED FIXED 28678
WebInspector: Only expand local scope when hitting the break 
https://bugs.webkit.org/show_bug.cgi?id=28678
Summary WebInspector: Only expand local scope when hitting the break
Pavel Feldman
Reported 2009-08-24 08:39:52 PDT
Currently all the scopes are being expanded (CallFrame change regression).
Attachments
patch (1.28 KB, patch)
2009-08-24 08:41 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
same with unused parameter cleanup (1.86 KB, application/octet-stream)
2009-08-24 09:05 PDT, Pavel Feldman 		no flags
Details
same with unused parameter cleanup (1.86 KB, patch)
2009-08-24 09:06 PDT, Pavel Feldman 		timothy: review+
DetailsFormatted DiffDiff
second part of the fix (1.60 KB, patch)
2009-08-24 12:22 PDT, Pavel Feldman 		timothy: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2009-08-24 08:41:02 PDT
Created attachment 38480 [details] patch
Pavel Feldman
Comment 2 2009-08-24 09:05:18 PDT
Created attachment 38481 [details] same with unused parameter cleanup
Pavel Feldman
Comment 3 2009-08-24 09:06:08 PDT
Created attachment 38482 [details] same with unused parameter cleanup
Pavel Feldman
Comment 4 2009-08-24 09:41:22 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/InjectedScript.js M WebCore/inspector/front-end/ScopeChainSidebarPane.js Committed r47717
Pavel Feldman
Comment 5 2009-08-24 12:22:57 PDT
Created attachment 38492 [details] second part of the fix First patch prevents _all_ scopes from being expanded, which is not enough. I missed the part where local one is expanded.
Pavel Feldman
Comment 6 2009-08-24 13:21:20 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/ScopeChainSidebarPane.js Committed r47724
Note You need to log in before you can comment on or make changes to this bug.