Bug 28663 – [Gtk] API for disabling local file access to web URLs

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Jan Alonzo]

This is the Gtk component of https://bugs.webkit.org/show_bug.cgi?id=28480. Patch forthcoming..

[Jan Alonzo]

Created attachment 38445 [details]
Patch v1

[Xan Lopez]

Comment on attachment 38445 [details]
Patch v1

>      gboolean javascript_can_open_windows_automatically;
>      gboolean enable_offline_web_application_cache;
> +    gboolean enable_universal_access_from_file_uri;

from_file_uriS ?

>  };
>  
>  #define WEBKIT_WEB_SETTINGS_GET_PRIVATE(obj) (G_TYPE_INSTANCE_GET_PRIVATE((obj), WEBKIT_TYPE_WEB_SETTINGS, WebKitWebSettingsPrivate))
> @@ -130,7 +131,8 @@ enum {
>      PROP_ENABLE_XSS_AUDITOR,
>      PROP_USER_AGENT,
>      PROP_JAVASCRIPT_CAN_OPEN_WINDOWS_AUTOMATICALLY,
> -    PROP_ENABLE_OFFLINE_WEB_APPLICATION_CACHE
> +    PROP_ENABLE_OFFLINE_WEB_APPLICATION_CACHE,
> +    PROP_ENABLE_UNIVERSAL_ACCESS_FROM_FILE_URI

URIS ?

>  };
>  
>  // Create a default user agent string
> @@ -597,7 +599,21 @@ static void webkit_web_settings_class_init(WebKitWebSettingsClass* klass)
>                                                           TRUE,
>                                                           flags));
>  
> -
> +    /**
> +    * WebKitWebSettings:enable-universal-access-from-file-uri
> +    *
> +    * Whether to allow files loaded through file:// URIs universal access to
> +    * pages loaded through non-file schemes.

Isn't it just to all pages?

> +    *
> +    * Since 1.1.13
> +    */
> +    g_object_class_install_property(gobject_class,
> +                                    PROP_ENABLE_UNIVERSAL_ACCESS_FROM_FILE_URI,
> +                                    g_param_spec_boolean("enable-universal-access-from-file-uri",
> +                                                         _("Enable universal access from file URI"),

URIs ?

r=me with the name changes and the doc fixup in case it applies to all pages.

[Jan Alonzo]

(In reply to comment #2)
> 
> r=me with the name changes and the doc fixup in case it applies to all pages.

Landed as http://trac.webkit.org/changeset/47690. Thanks!

[Jan Alonzo]

Created attachment 38450 [details]
Enable setting for DRT

[Jan Alonzo]

Reopening as we need the setting enabled in DRT.

[Xan Lopez]

Comment on attachment 38450 [details]
Enable setting for DRT

r=me

[Jan Alonzo]

Comment on attachment 38450 [details]
Enable setting for DRT

Rejecting patch 38450 from commit-queue.  This patch will require manual commit.

WebKitTools/Scripts/build-webkit failed with exit code 2

[Jan Alonzo]

Comment on attachment 38450 [details]
Enable setting for DRT

Rejecting patch 38450 from commit-queue.  This patch will require manual commit.

Failed to run "['git', 'svn', 'rebase']"  exit_code: 1  cwd: None

[Jan Alonzo]

(In reply to comment #6)
> (From update of attachment 38450 [details])
> r=me

Landed as http://trac.webkit.org/changeset/47692