WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
28650
Remove cross-thread code from CrossOriginPreflightResultCache
https://bugs.webkit.org/show_bug.cgi?id=28650
Summary
Remove cross-thread code from CrossOriginPreflightResultCache
Dmitry Titov
Reported
2009-08-21 17:55:09 PDT
.. since it was there because XHR used it (and it can be used from Workers) and now it is only used from DocumentThreadedLoader, so it only is used on a main thread.
Attachments
Proposed patch
(3.94 KB, patch)
2009-08-21 17:59 PDT
,
Dmitry Titov
levin
: review+
levin
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dmitry Titov
Comment 1
2009-08-21 17:59:14 PDT
Created
attachment 38427
[details]
Proposed patch
David Levin
Comment 2
2009-08-21 18:08:19 PDT
Comment on
attachment 38427
[details]
Proposed patch
> diff --git a/WebCore/loader/CrossOriginPreflightResultCache.cpp b/WebCore/loader/CrossOriginPreflightResultCache.cpp > + static CrossOriginPreflightResultCache& cache = *new CrossOriginPreflightResultCache;
Please use DEFINE_STATIC_LOCAL here.
Dmitry Titov
Comment 3
2009-08-24 10:21:13 PDT
Changed to DYNAMIC_STATIC_LOCAL and landed:
http://trac.webkit.org/changeset/47659
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug