WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
286497
[WebDriver][BiDi] run-webdriver-tests: Selenium WebDriver-BiDi tests require extra pytest option
https://bugs.webkit.org/show_bug.cgi?id=286497
Summary
[WebDriver][BiDi] run-webdriver-tests: Selenium WebDriver-BiDi tests require ...
Lauro Moura
Reported
2025-01-24 12:58:28 PST
The selenium test suite update from
288959@main
added some WebDriver-BiDi tests. The suite uses the custom `--bidi=true` pytest argument to tell Selenium to start the WebDriver session for testing with this feature enabled. Currently, this option is not passed to Selenium in WebDriverTestRunnerSelenium/WebDriverSeleniumExecutor. So, running Selenium's WebDriver-BiDi tests fails, regardless of having the feature enabled through `ENABLE_WEBDRIVER_BIDI=1`. We can't also set it as a fixed flag, as it would make the classic tests to fail in ENABLE_WEBDRIVER_BIDI=0 builds (due to failure to set up the WebDriver-BiDi session).
Attachments
Add attachment
proposed patch, testcase, etc.
Lauro Moura
Comment 1
2025-01-24 19:33:33 PST
Pull request:
https://github.com/WebKit/WebKit/pull/39207
Lauro Moura
Comment 2
2025-01-24 19:55:15 PST
Pull request:
https://github.com/WebKit/WebKit/pull/39538
Lauro Moura
Comment 3
2025-01-27 06:10:53 PST
(In reply to Lauro Moura from
comment #1
)
> Pull request:
https://github.com/WebKit/WebKit/pull/39207
Please ignore this PR, as it is related to
bug286163
and was attached to this bug by accident. The correct one is
https://github.com/WebKit/WebKit/pull/39538
EWS
Comment 4
2025-01-28 08:31:19 PST
Committed
289454@main
(9a82bd160050): <
https://commits.webkit.org/289454@main
> Reviewed commits have been landed. Closing PR #39538 and removing active labels.
Radar WebKit Bug Importer
Comment 5
2025-01-28 08:32:25 PST
<
rdar://problem/143761444
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug