WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
286311
Factor out hasSingleLine logic for inline box iterator
https://bugs.webkit.org/show_bug.cgi?id=286311
Summary
Factor out hasSingleLine logic for inline box iterator
fantasai
Reported
2025-01-21 11:20:06 PST
We have a lot of bool hasSingleLine = !m_inlineBox.nextInlineBoxLineLeftward() && !m_inlineBox.nextInlineBoxLineRightward(); checks. It would make sense to factor this out into its own method on m_inlineBox.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2025-01-21 11:20:16 PST
<
rdar://problem/143332919
>
fantasai
Comment 2
2025-01-21 11:22:52 PST
Pull request:
https://github.com/WebKit/WebKit/pull/39329
EWS
Comment 3
2025-01-25 12:53:35 PST
Committed
289392@main
(e2cc160e3d0d): <
https://commits.webkit.org/289392@main
> Reviewed commits have been landed. Closing PR #39329 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug