NEW286274
[WebDriver] Properly use smart pointers instead of raw pointers for the HTTPServer, WebSocketServer, and WebDriverService 
https://bugs.webkit.org/show_bug.cgi?id=286274
Summary [WebDriver] Properly use smart pointers instead of raw pointers for the HTTPS...
Lauro Moura
Reported 2025-01-20 13:46:47 PST
In WebDriverBiDi's a number of classes (WebDriverService, HTTPServer, WebSocketServer) held each other through plain references, and, in the case of WebSocketServer, mixed with WeakPtr usage. We should make them use smart pointers correctly, per our safer cpp guidelines: https://github.com/WebKit/WebKit/wiki/Safer-CPP-Guidelines#use-smart-pointers-instead-of-raw-pointers-for-all-data-members Patch incoming.
Attachments
Add attachment proposed patch, testcase, etc.
Lauro Moura
Comment 1 2025-01-20 19:05:30 PST
Pull request: https://github.com/WebKit/WebKit/pull/39310
Radar WebKit Bug Importer
Comment 2 2025-01-27 13:47:11 PST
<rdar://problem/143715487>
Lauro Moura
Comment 3 2025-04-24 18:50:02 PDT
(In reply to Lauro Moura from comment #1) > Pull request: https://github.com/WebKit/WebKit/pull/39310 This PR was closed in favor of a simpler fix in bug291925. We can revisit it later
Note You need to log in before you can comment on or make changes to this bug.