RESOLVED FIXED 286273
[WPE][GTK] libsysprof-capture contains GPLv3+ sources
https://bugs.webkit.org/show_bug.cgi?id=286273
Summary [WPE][GTK] libsysprof-capture contains GPLv3+ sources
Michael Catanzaro
Reported 2025-01-20 12:26:11 PST
The license of Source/ThirdParty/libsysprof-capture/mapped-ring-buffer.c and mapped-ring-buffer.h is GPL-3.0-or-later. Fortunately this is probably just a mistake. Looks like the intended license is BSD-2-Clause-Patent and these files were just missed in https://gitlab.gnome.org/GNOME/sysprof/-/commit/532972beb66f6db4e9e71933e849dc8529d49be0. I have inquired about relicensing these files. Maybe we need an EWS to run licensecheck for us so we cannot forget.
Attachments
Michael Catanzaro
Comment 1 2025-01-20 12:41:24 PST
There are also several tests: Source/ThirdParty/libsysprof-capture/tests/allocs-by-size.c: * the Free Software Foundation, either version 3 of the License, or Source/ThirdParty/libsysprof-capture/tests/cross-thread-frees.c: * the Free Software Foundation, either version 3 of the License, or Source/ThirdParty/libsysprof-capture/tests/find-temp-allocs.c: * the Free Software Foundation, either version 3 of the License, or Source/ThirdParty/libsysprof-capture/tests/rewrite-pid.c: * the Free Software Foundation, either version 3 of the License, or Source/ThirdParty/libsysprof-capture/tests/test-capture-cursor.c: * the Free Software Foundation, either version 3 of the License, or But we can simply delete these, and add a note to our WebKit README mentioning to not import them again.
Christian Hergert
Comment 2 2025-01-20 13:09:00 PST
It was indeed a mistake. Source is updated to match the other BSD licenses.
Michael Catanzaro
Comment 3 2025-01-20 13:44:42 PST
Thank you!
Michael Catanzaro
Comment 4 2025-01-20 13:46:59 PST
EWS
Comment 5 2025-01-23 09:38:10 PST
Committed 289297@main (e4ef1b87b839): <https://commits.webkit.org/289297@main> Reviewed commits have been landed. Closing PR #39299 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.