Bug 28617 - Fix CSSKeyframesRule & CSSKeyframeRule types in the IDL
Summary: Fix CSSKeyframesRule & CSSKeyframeRule types in the IDL
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Minor
Assignee: Chris Marrin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-21 10:36 PDT by LEPESME Jean-Baptiste
Modified: 2010-06-11 13:48 PDT (History)
2 users (show)

See Also:


Attachments
Sample (403 bytes, text/html)
2009-08-21 10:36 PDT, LEPESME Jean-Baptiste
no flags Details
change VARIABLES_RULES to 9, and set the correct value to KEYFRAMES_RULE and KEYFRAME_RULE (1.17 KB, patch)
2009-08-21 18:38 PDT, LEPESME Jean-Baptiste
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description LEPESME Jean-Baptiste 2009-08-21 10:36:47 PDT
Created attachment 38380 [details]
Sample

Found in Chrome 4.0.202.0 (532.0), but same problem with Safari 4.0.3 (531.9.1).

I apologize if i missunderstood something. I searched but found nothing about this.

http://www.w3.org/TR/css3-animations/#dom-interfaces- it' s wrote :
  interface CSSRule {
    ...
    const unsigned short KEYFRAMES_RULE = 7;
    const unsigned short KEYFRAME_RULE = 8;
    ...
  };

And WebKitCSSKeyframesRule and WebKitCSSKeyframeRule seems to have a bad ".type" value.

What is the expected result?
  [object WebKitCSSKeyframesRule].type = 7
  [object WebKitCSSKeyframeRule].type = 8

What happens instead?
  [object WebKitCSSKeyframesRule].type = 8
  [object WebKitCSSKeyframeRule].type = 9

Bye,
Jiboo.
Comment 1 LEPESME Jean-Baptiste 2009-08-21 18:38:54 PDT
Created attachment 38428 [details]
change VARIABLES_RULES to 9, and set the correct value to KEYFRAMES_RULE and KEYFRAME_RULE
Comment 2 LEPESME Jean-Baptiste 2009-08-21 18:44:14 PDT
I made some research and I figured out that the css-variables features of webkit is non "standard" and not intended to be a part of CSS3.

It seems to be based on http://disruptive-innovations.com/zoo/cssvariables/ wich use RuleType number 7.

As css-animations should be in CSS3, i think that webkit had to change VARIABLES_RULES to another value to respect http://www.w3.org/TR/css3-animations/ .

Bye,
Jiboo.
Comment 3 Simon Fraser (smfr) 2010-05-27 22:28:41 PDT
We should really be using values outside the reserved range for features that are not yet in CR.