Bug 28611 - Middle click panning icon is offset by 3 pixels
Summary: Middle click panning icon is offset by 3 pixels
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P5 Trivial
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-21 04:39 PDT by philippe.beauchamp
Modified: 2009-08-21 12:02 PDT (History)
4 users (show)

See Also:


Attachments
Changed middlePanningCursor icon size constant and hotspot (1.68 KB, patch)
2009-08-21 05:10 PDT, philippe.beauchamp
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description philippe.beauchamp 2009-08-21 04:39:01 PDT
Reproducing the bug:
Open any Web page 
Click on the Middle mouse button to start panning without moving the mouse. 

Two Panning icons overlap with a 3x3pixels offset. 

Panning arrows are also offset by 3x3 pixels during panning action.
Comment 1 philippe.beauchamp 2009-08-21 05:10:05 PDT
Created attachment 38368 [details]
Changed middlePanningCursor icon size constant and hotspot
Comment 2 Eric Seidel (no email) 2009-08-21 09:19:01 PDT
I don't think you actually want hyatt here. :)

I'm surprised we don't get the dimensions from the icon directly instead of hard-coding them.

This looks fine, but I'd like one of the windows folks to say OK.  (When they do, they can also mark this commit-queue+ since you're not a committer.)
Comment 3 Adam Roben (:aroben) 2009-08-21 09:55:40 PDT
Comment on attachment 38368 [details]
Changed middlePanningCursor icon size constant and hotspot 

Looks fine to me, though I agree it isn't great that we are hard-coding these numbers.
Comment 4 Eric Seidel (no email) 2009-08-21 12:02:29 PDT
Comment on attachment 38368 [details]
Changed middlePanningCursor icon size constant and hotspot 

Clearing flags on attachment: 38368

Committed r47636: <http://trac.webkit.org/changeset/47636>
Comment 5 Eric Seidel (no email) 2009-08-21 12:02:33 PDT
All reviewed patches have been landed.  Closing bug.