Bug 286087 – [Tools][CISupport] start-local-buildbot-server fails to import modules from 'Shared' directory

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Carlos Alberto Lopez Perez]

Since 286664@main on the factories.py file for build-webkit-org and ews-build there is an import from the 'Shared' directory

Tools/CISupport/build-webkit-org/factories.py:from Shared.steps import *
Tools/CISupport/ews-build/factories.py:from Shared.steps import *

And this is currently causing an issue when trying a test deployment with start-local-buildbot-server because the script is not currently copying to the test workdir the Shared directory.


2025-01-16T21:12:31+0100 [-] Loading buildbot.tac...
2025-01-16T21:12:32+0100 [-] Loaded.
2025-01-16T21:12:32+0100 [twisted.scripts._twistd_unix.UnixAppLogger#info] twistd 21.2.0 (/tmp/tmpji3z4wyc/venv/bin/python 3.11.2) starting up.
2025-01-16T21:12:32+0100 [twisted.scripts._twistd_unix.UnixAppLogger#info] reactor class: twisted.internet.epollreactor.EPollReactor.
2025-01-16T21:12:32+0100 [-] Starting BuildMaster -- buildbot.version: 2.10.5
2025-01-16T21:12:32+0100 [-] Loading configuration from '/tmp/tmpji3z4wyc/ews-build/master.cfg'
2025-01-16T21:12:32+0100 [-] unable to import dnotify, so Maildir will use polling instead
2025-01-16T21:12:32+0100 [-] error while parsing config file:
	Traceback (most recent call last):
	  File "/tmp/tmpji3z4wyc/venv/lib/python3.11/site-packages/twisted/python/threadpool.py", line 254, in <lambda>
	    inContext.theWork = lambda: context.call(  # type: ignore[attr-defined]
	  File "/tmp/tmpji3z4wyc/venv/lib/python3.11/site-packages/twisted/python/context.py", line 118, in callWithContext
	    return self.currentContext().callWithContext(ctx, func, *args, **kw)
	  File "/tmp/tmpji3z4wyc/venv/lib/python3.11/site-packages/twisted/python/context.py", line 83, in callWithContext
	    return func(*args, **kw)
	  File "/tmp/tmpji3z4wyc/venv/lib/python3.11/site-packages/buildbot/config.py", line 154, in loadConfig
	    filename, config_dict = loadConfigDict(
	--- <exception caught here> ---
	  File "/tmp/tmpji3z4wyc/venv/lib/python3.11/site-packages/buildbot/config.py", line 117, in loadConfigDict
	    execfile(filename, localDict)
	  File "/tmp/tmpji3z4wyc/venv/lib/python3.11/site-packages/twisted/python/compat.py", line 225, in execfile
	    exec(code, globals, locals)
	  File "/tmp/tmpji3z4wyc/ews-build/master.cfg", line 12, in <module>
	    loadConfig = importlib.import_module("ews-build.loadConfig")
	  File "/usr/lib/python3.11/importlib/__init__.py", line 126, in import_module
	    return _bootstrap._gcd_import(name[level:], package, level)
	  File "<frozen importlib._bootstrap>", line 1206, in _gcd_import
	    
	  File "<frozen importlib._bootstrap>", line 1178, in _find_and_load
	    
	  File "<frozen importlib._bootstrap>", line 1149, in _find_and_load_unlocked
	    
	  File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
	    
	  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
	    
	  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
	    
	  File "/tmp/tmpji3z4wyc/ews-build/loadConfig.py", line 37, in <module>
	    from .factories import (APITestsFactory, BindingsFactory, BuildFactory, CommitQueueFactory, Factory, GTKBuildFactory,
	  File "/tmp/tmpji3z4wyc/ews-build/factories.py", line 28, in <module>
	    from Shared.steps import *
	builtins.ModuleNotFoundError: No module named 'Shared'
	
2025-01-16T21:12:32+0100 [-] Configuration Errors:
2025-01-16T21:12:32+0100 [-]   error while parsing config file: No module named 'Shared' (traceback in logfile)
2025-01-16T21:12:32+0100 [-] Halting master.
2025-01-16T21:12:32+0100 [-] BuildMaster startup failed
2025-01-16T21:12:32+0100 [-] BuildMaster is stopped
2025-01-16T21:12:32+0100 [-] Main loop terminated.
2025-01-16T21:12:32+0100 [twisted.scripts._twistd_unix.UnixAppLogger#info] Server Shut Down.

[Carlos Alberto Lopez Perez]

Pull request: https://github.com/WebKit/WebKit/pull/39142

[Radar WebKit Bug Importer]

<rdar://problem/143512057>

[EWS]

Committed 289345@main (966ff65d4726): <https://commits.webkit.org/289345@main>

Reviewed commits have been landed. Closing PR #39142 and removing active labels.