WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
286061
[GLib] Remove all GLIB_CHECK_VERSION conditionals
https://bugs.webkit.org/show_bug.cgi?id=286061
Summary
[GLib] Remove all GLIB_CHECK_VERSION conditionals
Adrian Perez
Reported
2025-01-16 06:02:20 PST
The oldest Linux distribution we need to support in 2025 is Ubuntu 22.04, which ships GLib 2.72.x - and all the GLIB_CHECK_VERSION condiotionals are for previos versions: % rg -tcpp -F '#if GLIB_CHECK_VERSION(' --no-filename Source/{WTF,JavaScriptCore/,Web{Core,Kit}} | sort -u #if GLIB_CHECK_VERSION(2, 59, 0) #if GLIB_CHECK_VERSION(2, 60, 0) #if GLIB_CHECK_VERSION(2, 69, 0) #if GLIB_CHECK_VERSION(2, 69, 1) % rg -tcpp -F '#if GLIB_CHECK_VERSION(' Source/{WTF,JavaScriptCore/,Web{Core,Kit}} | wl -l 24 % This means that we could change Source/cmake/Options{GTK,WPE}.cmake to check for GLib 2.69.1+, and drop all the GLib-version conditional blocks. Dependencies policy:
https://docs.webkit.org/Ports/WebKitGTK%20and%20WPE%20WebKit/DependenciesPolicy.html
Attachments
Add attachment
proposed patch, testcase, etc.
Adrian Perez
Comment 1
2025-01-16 06:22:13 PST
Pull request:
https://github.com/WebKit/WebKit/pull/39129
EWS
Comment 2
2025-01-23 15:33:47 PST
Committed
289318@main
(85b637b69f1c): <
https://commits.webkit.org/289318@main
> Reviewed commits have been landed. Closing PR #39129 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2025-01-23 15:34:15 PST
<
rdar://problem/143526406
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug