WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
285489
REGRESSION (
288228@main
): Compilation fails with Fuzzilli enabled
https://bugs.webkit.org/show_bug.cgi?id=285489
Summary
REGRESSION (288228@main): Compilation fails with Fuzzilli enabled
Jikai Ren
Reported
2025-01-06 19:27:41 PST
Bug Introduce Commit:
https://github.com/WebKit/WebKit/commit/e3bc80970566b176f6f2e02c0ffbf3323c0eb19e
Patch: ```diff diff --git a/Source/JavaScriptCore/fuzzilli/Fuzzilli.cpp b/Source/JavaScriptCore/fuzzilli/Fuzzilli.cpp index a3d45a9011c5..722e59816d9d 100644 --- a/Source/JavaScriptCore/fuzzilli/Fuzzilli.cpp +++ b/Source/JavaScriptCore/fuzzilli/Fuzzilli.cpp @@ -21,12 +21,18 @@ #include "config.h" #include "Fuzzilli.h" +#include <unistd.h> +#include <sys/mman.h> +#include <sys/stat.h> +#include <fcntl.h> + #include <mutex> #include <wtf/Assertions.h> #include <wtf/Compiler.h> #include <wtf/DataLog.h> #include <wtf/NeverDestroyed.h> #include <wtf/StdLibExtras.h> +#include <wtf/text/ASCIILiteral.h> #if ENABLE(FUZZILLI) @@ -139,7 +145,7 @@ void Fuzzilli::initializeReprl() WRITE_TO_FUZZILLI(helo.data(), helo.size()); READ_FROM_FUZZILLI(helo.data(), helo.size()); - RELEASE_ASSERT_WITH_MESSAGE(equalSpans(helo, "HELO"_span), "[REPRL] Invalid response from parent"); + RELEASE_ASSERT_WITH_MESSAGE(equalSpans(std::span{helo}, "HELO"_span), "[REPRL] Invalid response from parent"); // Mmap the data input buffer. reprlInputData = static_cast<char*>(mmap(0, REPRL_MAX_DATA_SIZE, PROT_READ | PROT_WRITE, MAP_SHARED, REPRL_DRFD, 0)); ```
Attachments
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2025-01-07 08:50:58 PST
Thank you for the report! Would you be willing to submit the patch as a GitHub PR for merging into WebKit,
https://webkit.org/contributing-code/
?
Jikai Ren
Comment 2
2025-01-07 17:50:09 PST
(In reply to Alexey Proskuryakov from
comment #1
)
> Thank you for the report! Would you be willing to submit the patch as a > GitHub PR for merging into WebKit,
https://webkit.org/contributing-code/
?
Sure. Progress will be updated here later.
Jikai Ren
Comment 3
2025-01-07 18:54:58 PST
Pull request:
https://github.com/WebKit/WebKit/pull/38696
Alexey Proskuryakov
Comment 4
2025-01-09 11:33:37 PST
https://commits.webkit.org/288622@main
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug