RESOLVED FIXED285453
Convert scroll-padding/scroll-margin types to strongly typed CSS/Style values 
https://bugs.webkit.org/show_bug.cgi?id=285453
Summary Convert scroll-padding/scroll-margin types to strongly typed CSS/Style values
Sam Weinig
Reported 2025-01-06 12:01:23 PST
Convert scroll-padding/scroll-margin types to strongly typed CSS/Style values.
Attachments
Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2025-01-06 12:05:44 PST
scroll-padding-* has the following grammar: <'scroll-padding-*'> = auto | <length-percentage [0,∞]> Historically this was represented in RenderStyle using a WebCore::Length, but we want something more strongly typed, that only includes `auto`, so we will need a new PrimitiveNumericOrKeyword<Numeric, Keywords...> to efficiently handle this. scroll-margin-* has the following grammar: // <'scroll-margin-*'> = <length> Like above, this has historically been handled by WebCore::Length, but we can do better! We can cut the amount of space in half by using a quad or Style::Length<> values which are 4 bytes each instead of the 8 used by WebCore::Length!
Sam Weinig
Comment 2 2025-01-06 12:27:18 PST
Pull request: https://github.com/WebKit/WebKit/pull/38587
Radar WebKit Bug Importer
Comment 3 2025-01-13 12:02:27 PST
<rdar://problem/142830546>
EWS
Comment 4 2025-01-13 20:17:08 PST
Committed 288829@main (f15f5a852578): <https://commits.webkit.org/288829@main> Reviewed commits have been landed. Closing PR #38587 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.