RESOLVED FIXED285437
Drive By Cleanup Of RenderTreeBuilderMultiColumn 
https://bugs.webkit.org/show_bug.cgi?id=285437
Summary Drive By Cleanup Of RenderTreeBuilderMultiColumn
Yulun Wu
Reported 2025-01-06 08:49:04 PST
We should make two small changes to RenderTreeBuilderMultiColumn to make it easier to follow: RenderTreeBuilder::MultiColumn::restoreColumnSpannersForContainer()'s argument order is reversed relative to other public functions in the class. Public/Private functions are intermingled in the .cc file and should be sorted.
Attachments
Add attachment proposed patch, testcase, etc.
Yulun Wu
Comment 1 2025-01-06 08:51:25 PST
I'd like to assign this to myself, not sure how to do it in this UI ._.
alan
Comment 2 2025-01-06 09:11:06 PST
Try clicking closer to the right edge of the dropdown where there's blank space (this is awful and has been reported)
Yulun Wu
Comment 3 2025-01-06 10:18:10 PST
<rdar://problem/142420503>
Yulun Wu
Comment 4 2025-01-06 10:18:29 PST
Pull request: https://github.com/WebKit/WebKit/pull/38571
Yulun Wu
Comment 5 2025-01-06 10:59:58 PST
Pull request: https://github.com/WebKit/WebKit/pull/38578
Yulun Wu
Comment 6 2025-01-06 12:57:46 PST
Thank you Zalan!
Yulun Wu
Comment 7 2025-01-06 12:57:55 PST
Thank you Zalan!
EWS
Comment 8 2025-01-06 15:46:03 PST
Committed 288490@main (a21e75a8191d): <https://commits.webkit.org/288490@main> Reviewed commits have been landed. Closing PR #38578 and removing active labels.
EWS
Comment 9 2025-01-14 11:29:08 PST
Committed 288871@main (c27ba7a1cf4d): <https://commits.webkit.org/288871@main> Reviewed commits have been landed. Closing PR #38571 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.