Bug 285286 – REGRESSION (284074@main): Absolute positioned child with percent should include containing block padding

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Ahmad Saleem]

Hi Team,

While going through Blink's commit, I came across another failing specifically in Safari / WebKit and from quick code scan, it seems we are doing right thing, so it might not be direct merge but something we might need to explore and fix.

Test Case (absolute-child-with-percent-padding-inside-relative-parent.html): https://jsfiddle.net/ma50ncsp/

^ Text `PASS` next to black container is not showing in WebKit ToT (Minibrowser)

Blink Commit: https://chromium.googlesource.com/chromium/src.git/+/9908f45b70b65fc242e050d33c67294fe870a1cb

WebKit Source below:

> `RenderTable.cpp` - https://searchfox.org/wubkat/rev/334d5acc1496f43ce5ffbc3abc190f145f9add1a/Source/WebCore/rendering/RenderTable.cpp#283

We are already calling `containingBlockLogicalWidthForContent()` here.

> `RenderBox.cpp` - https://searchfox.org/wubkat/rev/334d5acc1496f43ce5ffbc3abc190f145f9add1a/Source/WebCore/rendering/RenderBox.cpp#2261

return isOutOfFlowPositioned() ? containingBlock->clientLogicalWidth() : containingBlock->availableLogicalWidth();

^ In case of OOF - we are returning clientLogicalWidth similar to Blink's patch.

Just documenting, so we can track and fix the issue. Might need Antti or Alan's help here.

Thanks!

[Radar WebKit Bug Importer]

<rdar://problem/142321535>

[alan]

Created attachment 473768 [details]
[fast-cq]Patch

[EWS]

Committed 288460@main (1819b1a40777): <https://commits.webkit.org/288460@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 473768 [details].