RESOLVED FIXED 285094
AutoInstall.find_spec doesn't return a spec 
https://bugs.webkit.org/show_bug.cgi?id=285094
Summary AutoInstall.find_spec doesn't return a spec
Sam Sneddon [:gsnedders]
Reported 2024-12-22 23:13:41 PST
Currently we return a module-or-None: https://github.com/WebKit/WebKit/blob/31f53890413ab604b438db03c40f219b25f3ced1/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py#L700 Well, it's also unclear what the semantics of Loader.create_module(spec=None) is meant to be, but experimentally SourceFileLoader.create_module always returns none. This means that we always fall into the "If a spec cannot be found, None is returned", so our MetaPathFinder never actually finds anything (though it has side-effects, insofar as packages do get installed). It also means all the complex logic is for nothing, because all we're actually doing is returning None.
Attachments
Add attachment proposed patch, testcase, etc.
Sam Sneddon [:gsnedders]
Comment 1 2024-12-23 01:27:03 PST
Pull request: https://github.com/WebKit/WebKit/pull/38332
Radar WebKit Bug Importer
Comment 2 2024-12-29 23:14:18 PST
<rdar://problem/142167006>
EWS
Comment 3 2025-01-09 16:36:26 PST
Committed 288677@main (810335aedc77): <https://commits.webkit.org/288677@main> Reviewed commits have been landed. Closing PR #38332 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.